Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix including on purpose #2596

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Fix including on purpose #2596

merged 2 commits into from
Jun 11, 2021

Conversation

drdanz
Copy link
Member

@drdanz drdanz commented Jun 7, 2021 •
edited
Loading

Libraries

dev

  • The IVisualParams.h file was deprecated in favour of IRgbVisualParams.h
    and IDepthVisualParams.
  • All headers for the deprecated interfaces are now properly deprecated.

Depends on #2593, #2583, #2594, and #2595

@drdanz drdanz self-assigned this Jun 7, 2021
@drdanz drdanz force-pushed the fix_INCLUDING_ON_PURPOSE branch 2 times, most recently from d5df82c to 7ed5805 Compare June 11, 2021 07:53
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 07:55 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 07:55 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 07:55 Inactive
@drdanz drdanz force-pushed the fix_INCLUDING_ON_PURPOSE branch from 7ed5805 to a1d79b1 Compare June 11, 2021 08:38
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 11:35 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 11:35 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 13:14 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 13:14 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 13:14 Inactive
drdanz added 2 commits June 11, 2021 15:51
@drdanz
dev: Deprecate headers
2d772cb 
* Deprecate the IVisualParams.h file in favour of I{Rgb,Depth}VisualParams.h.
* Deprecate files for deprecated interfaces.
* Fix `INCLUDING_ON_PURPOSE` macros when deprecated files are included recursively.
@drdanz
Update release notes
33cb813
@drdanz drdanz force-pushed the fix_INCLUDING_ON_PURPOSE branch from a1d79b1 to 33cb813 Compare June 11, 2021 13:52
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 14:07 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 14:07 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 11, 2021 14:08 Inactive
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@drdanz
Copy link
Member Author

drdanz commented Jun 11, 2021

Valgrind failures seem to depend on some other reason. Merging this

@drdanz drdanz merged commit 1d5cbba into robotology:master Jun 11, 2021
@traversaro traversaro mentioned this pull request Jun 12, 2021
Closed
@pattacini pattacini mentioned this pull request Jun 12, 2021
Closed
@traversaro traversaro mentioned this pull request Jun 12, 2021
Merged
@pattacini pattacini mentioned this pull request Jun 12, 2021
Closed
@drdanz drdanz deleted the fix_INCLUDING_ON_PURPOSE branch June 14, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicogene Nicogene Awaiting requested review from Nicogene Nicogene is a code owner

@randaz81 randaz81 Awaiting requested review from randaz81 randaz81 is a code owner

@traversaro traversaro Awaiting requested review from traversaro traversaro is a code owner

Assignees

@drdanz drdanz

Labels
Component: Deprecated Component: Library - YARP_dev Resolution: Merged Target: YARP v3.5.0 Type: Cleanup Involves cleaning up some part of YARP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drdanz