Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing includes to ControlBoardInterfacesImpl.h file #2605

Merged
merged 1 commit into from
Jun 13, 2021

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Jun 12, 2021

The ControlBoardInterfacesImpl.h should include the ImplementPositionControl.h and ImplementVelocityControl.h headers that define the yarp::dev::ImplementPositionControl and yarp::dev::ImplementVelocityControl, but those were removed in #2596 . This PR restores them.

Fix part of robotology/robotology-superbuild#794 .

@traversaro traversaro requested a review from randaz81 as a code owner June 12, 2021 07:45
@update-docs
Copy link

update-docs bot commented Jun 12, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@traversaro
Copy link
Member Author

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

The PR fixes a regression that was not part of any release, so no changelog notice is necessary.

@drdanz drdanz merged commit de1da21 into robotology:master Jun 13, 2021
@drdanz drdanz added Component: Library - YARP_dev Target: YARP v3.5.0 Type: Regression This is related to something that worked in a previous version Resolution: Merged labels Jun 13, 2021
@drdanz
Copy link
Member

drdanz commented Jun 13, 2021

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Library - YARP_dev Resolution: Merged Target: YARP v3.5.0 Type: Regression This is related to something that worked in a previous version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants