Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change YARP_PLUM_BOB to YARP_PLUMB_BOB #2544

Closed
ste93 opened this issue Apr 8, 2021 · 3 comments
Closed

Change YARP_PLUM_BOB to YARP_PLUMB_BOB #2544

ste93 opened this issue Apr 8, 2021 · 3 comments
Labels
Component: Devices Component: Library - YARP_dev Fixed in: YARP v3.5.0 Issue Type: Bug Involves some intervention from a system administrator Resolution: Fixed Type: Breaking/Behaviour Change Involves breaking user code or behaviour

Comments

@ste93
Copy link
Contributor

ste93 commented Apr 8, 2021

I've noticed that PLUMB_BOB distortion is badly written in the code, we can update it to the right one to avoid incoerences.
@drdanz drdanz added Issue Type: Bug Involves some intervention from a system administrator Type: Breaking/Behaviour Change Involves breaking user code or behaviour labels Apr 13, 2021
@drdanz
Copy link
Member

drdanz commented Apr 13, 2021

We need to pay attention since the enum class YarpDistortion is part of the public API.
If we want to do it clean, we should keep both names, declaring one deprecated...
Anyway, it seems to be used only in YARP and yarp-device-realsense2, as long as they are kept in sync, I think there should not be a problem in breaking the API

@ste93
Copy link
Contributor Author

ste93 commented Apr 14, 2021

I've also opened an issue in yarp-device-realsense2 robotology/yarp-device-realsense2#10

@ste93 ste93 mentioned this issue Apr 14, 2021
Closed
@drdanz drdanz closed this as completed Jul 2, 2021
@ste93 ste93 mentioned this issue Apr 5, 2022
Merged
@traversaro
Copy link
Member

For reference, this was fixed by #2593 that was eventually released as part of YARP 3.5 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Devices Component: Library - YARP_dev Fixed in: YARP v3.5.0 Issue Type: Bug Involves some intervention from a system administrator Resolution: Fixed Type: Breaking/Behaviour Change Involves breaking user code or behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drdanz @traversaro @ste93