feat(remix-node): only polyfill globals if they're not present

[MichaelDeBoey]

Closes #5858
Closes #6280
Closes #6284
Closes #6288
Closes #6290
Closes #6318
Closes #6348
Closes #6380

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3618a82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[isker]

I'm not sure it will be as easy as this. Before I gave up on using remix for my project, I had to patch other parts of it which were relying on polyfill implementation details in order to get rid of the polyfills: isker/neogrok@c47fc1c#diff-49b936c82e6771ef5a3b352fb8cc1fef5a732a395be7a2bb56ac508bf90e7f79.

(I didn't bother looking into what the semantics of raw in the polyfill were, which might influence how serious this change would be.)

[brophdawg11]

I'm not sure if this is what we want since we've found that the node globals aren't spec compliant. I believe @jacob-ebey was working on a new way in which we give users control on whether or not to add polyfills.

[machour]

Also beware, ||= is node >= 15. We want to maintain node 14 compatibility.

[MichaelDeBoey]

Also beware, ||= is node >= 15. We want to maintain node 14 compatibility.

Code will be transpiled to Node 14, no? 🤔

[machour]

Code will be transpiled to Node 14, no? 🤔

You're correct, I totally missed #5047, thanks!

[bryce-pearce]

@brophdawg11 @MichaelDeBoey

Are there any updates on that other approach you mentioned? It seems like this is a breaking issue for several people

#6284
#6280
#6290

[MichaelDeBoey]

Superseded by #6547