-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yjs throws error when using @remix-run/dev 1.16.0 #6290
Comments
@anton-g what future flags do you have enabled in |
Might be related to #6259 |
Just the defaults from create-remix:
Turning them off doesn't seem to make a difference. |
We just published version |
@anton-g Closing this as I can't reproduce this locally (tried with 1.15, 1.16 & 1.17) & the CodeSandbox you linked is working fine as well |
@MichaelDeBoey Tried with 1.17.1-pre.0 and seems to be working now! Great job! 🙌 |
@anton-g to be clear: when trying to reproduce this, it was already working in 1.15 |
What version of Remix are you using?
1.16.0
Are all your remix dependencies & dev-dependencies using the same version?
Steps to Reproduce
Version 1.16.0 of
@remix-run/dev
breaksyjs
. It works fine for 1.15.0 of@remix-run/dev
.I didn't know how to add a test for this specific case, but here's a CodeSandbox with reproduction: https://codesandbox.io/p/github/anton-g/remix-yjs-error/main
Steps to recreate from scratch:
Add the following to the top of
_index.js
:Run the app (
npm run dev
) and refresh the page.Expected Behavior
New yjs Doc created successfully on page load.
Actual Behavior
Client crashes with error:
The text was updated successfully, but these errors were encountered: