feat(remix-dev): introduce serverNodeBuiltinsPolyfill config option
#6547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MichaelDeBoey
changed the title
serverNodeBuiltinsPolyfill config option + replace esbuild-plugin-polyfill-node with esbuild-plugins-node-modules-polyfill
This was referenced Jun 6, 2023
1 task
MichaelDeBoey
approved these changes
Jun 6, 2023
| "from `true` to `false` regardless of platform. You can prepare for this change by explicitly specifying " + | ||
| "serverNodeBuiltinsPolyfill: false` or `serverNodeBuiltinsPolyfill: true` if you are currently relying on them. " + | ||
| "For instructions on making this change see " + | ||
| "https://remix.run/docs/en/v1.16.0/pages/v2#servernodebuiltinspolyfill"; |
There was a problem hiding this comment.
This version number needs to be bumped to match the version this goes out in.
markdalgleish
approved these changes
Jun 7, 2023
1 task
1 task
jacob-ebey
changed the title
serverNodeBuiltinsPolyfill config option + replace esbuild-plugin-polyfill-node with esbuild-plugins-node-modules-polyfillserverNodeBuiltinsPolyfill config option
This was
unlinked from
issues
Jun 8, 2023
Co-authored-by: Ivo Todorov <[email protected]>
adds option to disable server node module polyfills for non-node platform targets retaining the existing behavior of today.
chore: add warning - rename config option - update tests
1 task
|
Closing in favour of #6814 which builds on top of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #6414