Optional web API polyfills in @remix-run/node

[isker]

Hi. I'm trying to convert a project to remix for the first time. Everything's going pretty well so far, but one thing about remix's node runtime has stood out to me: the web API polyfills. Things like fetch, FormData, the web streams API, etc.

Modern nodes provide implementations of every web API remix polyfills on the global object, but remix unconditionally sets its polyfills on the global object, blowing the native implementations away. I'd prefer to use the native ones as they are less liable to do things like crash the server when fetches are aborted 😬. Especially the undici fetch implementation that ships in node is benchmarked thoroughly and achieves very high performance.

I'm wondering if there's any path toward remix's node polyfills becoming explicitly optional, conditional on node version, conditional on being missing from the global object, etc. This is perhaps complicated by the fact that the node runtime exports many of its polyfilled implementations. I'm not sure this is possible without creating an entirely new runtime, new adapters, etc.

Thanks!

[isker]

For something to compare to, you can see that next only conditionally polyfills fetch.

[aniravi24]

I'm curious about this as well, because I'm actually running into issues that appear to be caused by the polyfills. The open PRs and issues about the custom polyfills also have been unresolved for a long time.

For example, I'm unable to use AbortController correctly.
See issue here

[MichaelDeBoey]

I created a PR to implement this: #6259

[MichaelDeBoey]

We just published version 1.17.1-pre.0 which includes #6562 (a possible fix). If you'd like to take it for a test run please try it out and let us know what you think!

[KyleAMathews]

Undici is still broken on 1.17.1 (edit: looks like in general Remix isn't ready for Node 18/20)

    throw new TypeError(`${context} is not a ReadableStream.`);
          ^
TypeError: First parameter has member 'readable' that is not a ReadableStream.

[jorisre]

I'm encountering the same error too. Has anyone discovered a solution?

[justinhenricks]

Also see the same issue when trying to use Youtube web loader from langchain

const loader = YoutubeLoader.createFromUrl("https://youtu.be/bZQun8Y4L2A", {
  language: "en",
  addVideoInfo: true,
});

const docs = await loader.load();