Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: STEP 6 Clean up un-used styles, remove SASS and move styles to component #2520

Closed
willmcvay opened this issue Aug 27, 2020 · 1 comment · Fixed by #2539, #2554, #2571, #2577 or #2715
Closed

Refactor: STEP 6 Clean up un-used styles, remove SASS and move styles to component #2520

willmcvay opened this issue Aug 27, 2020 · 1 comment · Fixed by #2539, #2554, #2571, #2577 or #2715
Labels
developer-portal feature New feature or request front-end Relates to front end issues
Milestone
Marketplace v2.0

Comments

@willmcvay
Copy link
Contributor

Background context or User story:

  • We're using CSS module for styles of the marketplace and placed the file in this folder as below
    image

Specification or Acceptance Criteria:

  • We'll move SCSS file to the place where it is used, for example, the file as the image below should move to /src/pages/admin-app/__styles__/admin-app.scss and remove un-use styles
    And apply https://linaria.now.sh/ for styles, remove CSS modules
    image

Suggested solution:

  • Move SCSS file to correct place where it is used and apply https://linaria.now.sh/
  • Apply linaria cx case if else in styles
@willmcvay willmcvay added feature New feature or request front-end Relates to front end issues developer-portal labels Aug 27, 2020
@willmcvay willmcvay changed the title Refactor: STEP 6 Clean up un-use styles and move styles to it's component Refactor: STEP 6 Clean up un-used styles, remove SASS and move styles to component Aug 27, 2020
@nphivu414 nphivu414 self-assigned this Aug 31, 2020
nphivu414 added a commit that referenced this issue Aug 31, 2020
@nphivu414
fix: #2520 - Refactor app list + analytics page styles
e01c565
@nphivu414 nphivu414 mentioned this issue Aug 31, 2020
Merged
14 tasks
nphivu414 added a commit that referenced this issue Sep 1, 2020
@nphivu414
fix: #2520 - Remove thread-loader to avoid conflicts with linaria in …
b66de28 
…prod build
nphivu414 added a commit that referenced this issue Sep 1, 2020
@nphivu414
fix: #2520 - Refactor app list + analytics page styles (#2539)
558f948
nphivu414 pushed a commit that referenced this issue Sep 1, 2020
fix: #2520 - Refactor login + register + welcome page styles
0923a04
nphivu414 pushed a commit that referenced this issue Sep 3, 2020
fix: #2520 - Remove unused styles + refactor app revision styles
468280a
@nphivu414 nphivu414 mentioned this issue Sep 3, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Sep 3, 2020
fix: #2520 - Use linaria cx for conditional styles
0d7e440
nphivu414 pushed a commit that referenced this issue Sep 3, 2020
fix: #2520 - Remove unused logs
46453aa
nphivu414 pushed a commit that referenced this issue Sep 3, 2020
refactor: #2520 remove unused styles + refactor app revision styles (#…
1412699 
…2554)
nphivu414 added a commit that referenced this issue Sep 4, 2020
@nphivu414
fix: #2520 - refactor terms and condition modal styles
e6fb151
nphivu414 added a commit that referenced this issue Sep 4, 2020
@nphivu414
fix: #2520 - Refactor standalone app page styles
626a58c
@nphivu414 nphivu414 mentioned this issue Sep 4, 2020
Merged
14 tasks
nphivu414 added a commit that referenced this issue Sep 4, 2020
@nphivu414
fix: #2520 - Remove important codes + revert register testing codes
b318f54
nphivu414 added a commit that referenced this issue Sep 4, 2020
@nphivu414
refactor: #2520 Refactor Standalone App Page + terms and condition mo…
c124159 
…dal styles (#2571)
nphivu414 added a commit that referenced this issue Sep 4, 2020
@nphivu414
fix: #2520 - Refactor submit app modal styles + global styles
6a219c4
@nphivu414 nphivu414 mentioned this issue Sep 4, 2020
Merged
14 tasks
nphivu414 added a commit that referenced this issue Sep 4, 2020
@nphivu414
fix: #2520 - Remove unused comments
f5f6138
nphivu414 added a commit that referenced this issue Sep 7, 2020
@nphivu414
refactor: #2520 Refactor submit app modal styles + global styles (#2577)
921428f
@AshDeeming
Copy link

AshDeeming commented Sep 11, 2020 •
edited
Loading

@nphivu414 - The category section text appears to have the wrong background colour showing.

Currently visable:
image

Should be as per below & original design:
image

nphivu414 pushed a commit that referenced this issue Sep 15, 2020
fix: #2520 - Fix wrong tag background color
9c256f6
@nphivu414 nphivu414 mentioned this issue Sep 15, 2020
Merged
14 tasks
duong-se pushed a commit that referenced this issue Sep 15, 2020
fix: #2520 fix wrong tag background color (#2715)
89205a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer-portal feature New feature or request front-end Relates to front end issues
Projects
None yet
Milestone
Marketplace v2.0
3 participants
@willmcvay @nphivu414 @AshDeeming