refactor: #2520 remove unused styles + refactor app revision styles #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor/2520-clean-up-styles-dev-portal
vuhuucuong
approved these changes
Sep 3, 2020
duong-se
reviewed
Sep 3, 2020
| <div className={`${styles.block} ${blockStyle} ${isDiff ? styles.red : ''}`}> | ||
| <div className={`${styles.image} ${imageStyle}`} style={{ backgroundImage: `url("${currentMedia}")` }} /> | ||
| <div className={container}> | ||
| <div className={`${block} ${blockStyle} ${isDiff ? red : ''}`}> |
There was a problem hiding this comment.
Could you change to use cx ?
duong-se
reviewed
Sep 3, 2020
| <div className={`${styles.image} ${imageStyle}`} style={{ backgroundImage: `url("${currentMedia}")` }} /> | ||
| <div className={container}> | ||
| <div className={`${block} ${blockStyle} ${isDiff ? red : ''}`}> | ||
| <div className={`${image} ${imageStyle}`} style={{ backgroundImage: `url("${currentMedia}")` }} /> |
There was a problem hiding this comment.
Could you change to use cx ?
duong-se
reviewed
Sep 3, 2020
| <div className={`${styles.block} ${blockStyle} ${isDiff ? styles.green : ''}`}> | ||
| <div className={`${styles.image} ${imageStyle}`} style={{ backgroundImage: `url("${changedMedia}")` }} /> | ||
| <span className={arrow}>→</span> | ||
| <div className={`${block} ${blockStyle} ${isDiff ? green : ''}`}> |
There was a problem hiding this comment.
Could you change to use cx ?
duong-se
reviewed
Sep 3, 2020
| <div className={`${styles.image} ${imageStyle}`} style={{ backgroundImage: `url("${changedMedia}")` }} /> | ||
| <span className={arrow}>→</span> | ||
| <div className={`${block} ${blockStyle} ${isDiff ? green : ''}`}> | ||
| <div className={`${image} ${imageStyle}`} style={{ backgroundImage: `url("${changedMedia}")` }} /> |
There was a problem hiding this comment.
Could you change to use cx ?
duong-se
reviewed
Sep 3, 2020
| <span className={styles.arrow}>→</span> | ||
| <HTMLRender className={`${styles.diffRenderBlock} ${isDiff ? styles.green : ''}`} html={changedString || ''} /> | ||
| <div className={diffRenderHtmlContainer}> | ||
| <HTMLRender className={`${diffRenderBlock} ${isDiff ? red : ''}`} html={currentString || ''} /> |
There was a problem hiding this comment.
Could you change to use cx ?
duong-se
reviewed
Sep 3, 2020
| <div className={diffRenderHtmlContainer}> | ||
| <HTMLRender className={`${diffRenderBlock} ${isDiff ? red : ''}`} html={currentString || ''} /> | ||
| <span className={arrow}>→</span> | ||
| <HTMLRender className={`${diffRenderBlock} ${isDiff ? green : ''}`} html={changedString || ''} /> |
There was a problem hiding this comment.
Could you change to use cx ?
duong-se
reviewed
Sep 3, 2020
| @@ -20,12 +20,12 @@ const diffTypes = { | |||
| const DiffViewer = ({ currentString, changedString, type = 'words' }: DiffViewerProps) => { | |||
| const result = diffTypes[type](currentString, changedString).map((part, index) => { | |||
| return ( | |||
| <span key={index} className={part.added ? styles.green : part.removed ? styles.red : ''}> | |||
| <span key={index} className={part.added ? green : part.removed ? red : ''}> | |||
There was a problem hiding this comment.
Could you change to use cx ?
duong-se
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Does this close any currently open issues?
fixes: #2520
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn lint) has passed locally and any fixes were made for failuresyarn test) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #2520
What is the new behavior?
Does this introduce a breaking change?
Other information