fix: #2520 - Refactor app list + analytics page styles #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactor/2520-refactor-styles-in-developer-portal
duong-se
reviewed
Sep 1, 2020
|
|
||
| export const authenticationCode = css` | ||
| word-break: break-all; | ||
| margin-bottom: 0 !important; |
There was a problem hiding this comment.
Can we remove !important ?
There was a problem hiding this comment.
Hi @tanphamhaiduong ,
I'll fix it in the next PR
ant066
approved these changes
Sep 1, 2020
duong-se
reviewed
Sep 1, 2020
| @@ -28,7 +28,7 @@ export const AppList: React.FunctionComponent<AppListProps> = ({ | |||
| : 'We are unable to find any Apps that match your search criteria. Please try again.'} | |||
| </Helper> | |||
| ) : ( | |||
| <GridFourCol className={` ${loading ? styles.contentIsLoading : ''}`} data-test="app-list-container"> | |||
| <GridFourCol className={` ${loading ? contentIsLoading : ''}`} data-test="app-list-container"> | |||
There was a problem hiding this comment.
Pls use cx(loading && contentIsLoading)
nphivu414
deleted the
refactor/2520-refactor-styles-in-developer-portal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Does this close any currently open issues?
fixes: #2520
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn lint) has passed locally and any fixes were made for failuresyarn test) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #2520
What is the new behavior?
Does this introduce a breaking change?
Other information