Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: #2520 Refactor submit app modal styles + global styles #2577

Merged
merged 13 commits into from
Sep 7, 2020

Conversation

nphivu414
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #2520

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2520

What is the new behavior?

  • Refactor submit app modal styles + global styles

Does this introduce a breaking change?

  • Yes
  • No

Other information

v

@@ -1,4 +1,4 @@
import '../styles/index.scss'
// import '../styles/index.scss'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this?

@nphivu414 nphivu414 merged commit 921428f into master Sep 7, 2020
@nphivu414 nphivu414 deleted the refactor/2520-clean-up-styles-dev-portal branch September 7, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: STEP 6 Clean up un-used styles, remove SASS and move styles to component
3 participants