Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a developer, I should be able to see a preview of my app listing #1127

Closed
willmcvay opened this issue Apr 30, 2020 · 2 comments · Fixed by #1431, #1548, #1573, #1610 or #1619
Closed

As a developer, I should be able to see a preview of my app listing #1127

willmcvay opened this issue Apr 30, 2020 · 2 comments · Fixed by #1431, #1548, #1573, #1610 or #1619
Assignees
@ant066
Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace
Milestone
Developer Portal ...

Comments

@willmcvay
Copy link
Contributor

willmcvay commented Apr 30, 2020 •
edited
Loading

Background context or User story:

See #1126 - using the standalone apps page, I should be able to see a preview of my app listing from the submit app and edit app pages. Depends on #1126 - do not start this until ticket has passed QA

Specification or Acceptance Criteria:

  • Should be a button at the bottom of the submit app form called "preview"
  • Should be a link on the developer standalone page that routes to this preview
  • Should load client/apps/:id page in a new tab, at the route developer/apps/:id/preview
@willmcvay willmcvay added feature New feature or request marketplace Relates to the Marketplace front-end Relates to front end issues labels Apr 30, 2020
@HollyJoyPhillips HollyJoyPhillips mentioned this issue May 11, 2020
Closed
@duong-se duong-se self-assigned this May 26, 2020
@duong-se
Copy link
Contributor

@willmcvay So I have a question. For the submitting app, the preview will proceed before or after submit the app?

@duong-se duong-se assigned ant066 and unassigned duong-se May 28, 2020
ant066 pushed a commit that referenced this issue May 29, 2020
feat: #1127 As a developer, I should be able to see a preview of my app
1de6b64
@ant066 ant066 mentioned this issue May 29, 2020
Merged
14 tasks
ant066 pushed a commit that referenced this issue Jun 2, 2020
chore: #1127 update test, var name
b9081d9
ant066 pushed a commit that referenced this issue Jun 2, 2020
chore: #1127 merge master
089ba9f
ant066 pushed a commit that referenced this issue Jun 2, 2020
chore: #1127 avoid load localStorage from client side
71da05a
ant066 pushed a commit that referenced this issue Jun 3, 2020
feat: #1127 As a developer, I should be able to see a preview of my a…
705a747 
…pp (#1431)
ant066 pushed a commit that referenced this issue Jun 4, 2020
chore: #1127 disabled preview button when submit new app
38d056a
@ant066 ant066 mentioned this issue Jun 4, 2020
Merged
14 tasks
ant066 pushed a commit that referenced this issue Jun 4, 2020
chore: #1127 disabled preview button when submit new app (#1548)
c9b0ba4
@HollyJoyPhillips
Copy link
Contributor

@ant066 Couple of things:

Please can you hide the 'Back to App' button and line above it when in preview mode
image

Can you also link this icon to the preview page (accessed from the standalone page from developer/apps:
image

ant066 pushed a commit that referenced this issue Jun 5, 2020
feat: #1127 preview app from app details page
59ac51b
@ant066 ant066 mentioned this issue Jun 5, 2020
Merged
14 tasks
ant066 pushed a commit that referenced this issue Jun 5, 2020
chore: #1127 add test for handleOpenAppPreview function
9611c4b
ant066 pushed a commit that referenced this issue Jun 5, 2020
feat: #1127 preview app from app details page (#1573)
689fc8f
phmngocnghia pushed a commit that referenced this issue Jun 5, 2020
feat: #1127 preview app from app details page (#1573)
eed3ee4
@phmngocnghia phmngocnghia mentioned this issue Jun 5, 2020
Closed
14 tasks
ant066 pushed a commit that referenced this issue Jun 8, 2020
chore: #1127 add categories data to preview
dc3cb0e
@ant066 ant066 mentioned this issue Jun 8, 2020
Merged
14 tasks
duong-se pushed a commit that referenced this issue Jun 8, 2020
chore: #1127 add categories data to preview (#1610)
0c814a9
ant066 pushed a commit that referenced this issue Jun 8, 2020
chore: #1127 enable preview button from submit app page
45691f1
@ant066 ant066 mentioned this issue Jun 8, 2020
Merged
14 tasks
ant066 pushed a commit that referenced this issue Jun 8, 2020
chore: #1127 update image preview app
2651677
ant066 pushed a commit that referenced this issue Jun 8, 2020
chore: #1127 update image preview app
bbf9547
ant066 pushed a commit that referenced this issue Jun 8, 2020
fix: #1127 enable preview button from submit app page (#1619)
2e362a2 
* chore: #1127 enable preview button from submit app page

* chore: #1127 update image preview app

* chore: #1127 update image preview app
duong-se pushed a commit that referenced this issue Jun 8, 2020
@duong-se
chore: #1127 add categories data to preview (#1610)
7c3c086
duong-se pushed a commit that referenced this issue Jun 8, 2020
@duong-se
chore: #1127 add categories data to preview (#1610)
3c6f482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ant066 ant066

Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
Milestone
Developer Portal Production Release
5 participants
@willmcvay @duong-se @ant066 @phmngocnghia @HollyJoyPhillips