feat: #1127 As a developer, I should be able to see a preview of my app #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
nphivu414,
phmngocnghia,
duong-se,
trankhacvy,
vuhuucuong and
willmcvay
ant066
added
the
do not merge
willmcvay
requested changes
Jun 1, 2020
packages/marketplace/src/components/pages/client-app-detail/client-app-detail.tsx
Outdated
Show resolved
Hide resolved
packages/marketplace/src/components/pages/developer-submit-app/developer-submit-app.tsx
Outdated
Show resolved
Hide resolved
duong-se
reviewed
Jun 1, 2020
packages/marketplace/src/components/pages/client-app-detail/client-app-detail.tsx
Show resolved
Hide resolved
duong-se
reviewed
Jun 1, 2020
packages/marketplace/src/components/pages/client-app-detail/client-app-detail.tsx
Outdated
Show resolved
Hide resolved
duong-se
reviewed
Jun 1, 2020
packages/marketplace/src/components/pages/client-app-detail/client-app-detail.tsx
Outdated
Show resolved
Hide resolved
duong-se
reviewed
Jun 1, 2020
packages/marketplace/src/components/pages/developer-submit-app/developer-submit-app.tsx
Outdated
Show resolved
Hide resolved
duong-se
reviewed
Jun 1, 2020
duong-se
reviewed
Jun 1, 2020
duong-se
removed
the
do not merge
added 2 commits
June 2, 2020 14:43
github-actions
bot
added
aml-checklist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Does this close any currently open issues?
fixes: #1127
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn lint) has passed locally and any fixes were made for failuresyarn test) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Can not see preview when edit app
Issue Number: #1127
What is the new behavior?
Create new route to preview the app while editing
Does this introduce a breaking change?
Other information