chore: #1127 disabled preview button when submit new app

reapit · Jun 4, 2020 · 38d056a · 38d056a
1 parent 84794fd
commit 38d056a
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 34 deletions.
diff --git a/...ents/pages/developer-submit-app/__test__/__snapshots__/developer-submit-app.test.tsx.snap b/...ents/pages/developer-submit-app/__test__/__snapshots__/developer-submit-app.test.tsx.snap
@@ -1974,21 +1974,6 @@ exports[`DeveloperSubmitApp should match a snapshot 1`] = `
                                     <div
                                       className="column  "
                                     >
-                                      <Component
-                                        onClick={[Function]}
-                                        type="button"
-                                        variant="primary"
-                                      >
-                                        <button
-                                          className="button  is-primary  "
-                                          data-test=""
-                                          disabled={false}
-                                          onClick={[Function]}
-                                          type="button"
-                                        >
-                                          Preview
-                                        </button>
-                                      </Component>
                                       <Component
                                         dataTest="submit-app-button"
                                         disabled={false}

diff --git a/packages/marketplace/src/components/pages/developer-submit-app/developer-submit-app.tsx b/packages/marketplace/src/components/pages/developer-submit-app/developer-submit-app.tsx
@@ -398,18 +398,20 @@ export const DeveloperSubmitApp: React.FC<DeveloperSubmitAppProps> = () => {
                     <LevelRight>
                       <Grid>
                         <GridItem>
-                          <Button
-                            onClick={handleOpenAppPreview({
-                              appDetails: appDetailState?.appDetailData?.data,
-                              values,
-                              scopes,
-                              appId: appid,
-                            })}
-                            variant="primary"
-                            type="button"
-                          >
-                            Preview
-                          </Button>
+                          {isSubmitRevision && (
+                            <Button
+                              onClick={handleOpenAppPreview({
+                                appDetails: appDetailState?.appDetailData?.data,
+                                values,
+                                scopes,
+                                appId: appid,
+                              })}
+                              variant="primary"
+                              type="button"
+                            >
+                              Preview
+                            </Button>
+                          )}
                           {!isSubmitApp && (
                             <Button onClick={goBackToApps} variant="primary" type="button">
                               Back To Apps

diff --git a/packages/marketplace/src/tests/badges/badge-branches.svg b/packages/marketplace/src/tests/badges/badge-branches.svg
diff --git a/packages/marketplace/src/tests/badges/badge-functions.svg b/packages/marketplace/src/tests/badges/badge-functions.svg
diff --git a/packages/marketplace/src/tests/badges/badge-lines.svg b/packages/marketplace/src/tests/badges/badge-lines.svg
diff --git a/packages/marketplace/src/tests/badges/badge-statements.svg b/packages/marketplace/src/tests/badges/badge-statements.svg
diff --git a/packages/web-components/src/common/styles/theme.ts b/packages/web-components/src/common/styles/theme.ts
@@ -154,14 +154,14 @@ export const generateThemeClasses = (
         }
 
         @media screen and (min-width: ${breakPoints?.laptop || '960px'}) and (max-width: ${breakPoints?.desktop ||
-      '1200px'}) {
+            '1200px'}) {
           & {
             width: 33.333333%;
           }
         }
 
         @media screen and (min-width: ${breakPoints?.tablet || '768px'}) and (max-width: ${breakPoints?.laptop ||
-      '960px'}) {
+            '960px'}) {
           & {
             width: 50%;
           }
@@ -185,7 +185,7 @@ export const generateThemeClasses = (
         }
 
         @media screen and (min-width: ${breakPoints?.mobile || '560px'}) and (max-width: ${breakPoints?.laptop ||
-      '960px'}) {
+            '960px'}) {
           & {
             width: 50%;
           }