Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1127 add categories data to preview #1610

Merged
merged 1 commit into from
Jun 8, 2020
Merged

fix: #1127 add categories data to preview #1610

merged 1 commit into from
Jun 8, 2020

Conversation

ant066
Copy link
Contributor

@ant066 ant066 commented Jun 8, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #1127

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Not save app category to localStorage when preview
Issue Number: #1127

What is the new behavior?

  • Save app category to localStorage when preview

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot requested review from vuhuucuong and willmcvay June 8, 2020 03:53
@github-actions github-actions bot added the marketplace Relates to the Marketplace label Jun 8, 2020
@auto-assign auto-assign bot requested review from phmngocnghia and duong-se June 8, 2020 03:54
duong-se
duong-se approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit 0c814a9 into master Jun 8, 2020
@duong-se duong-se deleted the chore/1127-update-preview-data branch June 8, 2020 04:22
duong-se pushed a commit that referenced this pull request Jun 8, 2020
@duong-se
chore: #1127 add categories data to preview (#1610)
7c3c086
duong-se pushed a commit that referenced this pull request Jun 8, 2020
@duong-se
chore: #1127 add categories data to preview (#1610)
3c6f482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@duong-se duong-se duong-se approved these changes

@willmcvay willmcvay Awaiting requested review from willmcvay

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

Assignees

@ant066 ant066

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a developer, I should be able to see a preview of my app listing
3 participants
@ant066 @duong-se @vuhuucuong