[REVIEW] Make NCCL root initialization configurable. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drobison00
added
enhancement
|
Rerun tests |
|
Tests currently failing in CI appear to be due to : rapidsai/ucx-py#668 |
cjnolet
requested changes
Jan 14, 2021
|
Rerun tests |
|
rerun tests |
|
@drobison00 this is a breaking change, right? Then cugraph will also need a similar PR to rapidsai/cuml#3386 to upgrade their tagged commit cc @afender @BradReesWork for vis |
|
@dantegd added a PR to reflect the changes: rapidsai/cugraph#1343 Once the raft update is merged, I can update git tags as well. |
dantegd
pushed a commit
to dantegd/raft
that referenced
this pull request
Jul 23, 2024
This PR enables host input arrays for `ivf_pq::build` and `ivf_pq::extend`. closes rapidsai#120 closes rapidsai#143 Authors: - Tamas Bela Feher (https://github.com/tfeher) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the raft comms implementation to support configurable NCCL root placement, updates scheduler and worker routine logging so that it is visible and usable in a multi-node deployment, and adds additional error handling to the NCCL initialization process to fail early if errors are encountered.
Updates resolve MNMG failures in out of band cuML algorithms where the DASK client does not have the ability to directly communicate with workers.
Unit tests are implemented and passing.
Closes rapidsai/cuml#3261