Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] API update to match RAFT PR #120 #3386

Merged
merged 5 commits into from
Jan 24, 2021
Merged

[REVIEW] API update to match RAFT PR #120 #3386

merged 5 commits into from
Jan 24, 2021

Conversation

drobison00
Copy link
Contributor

#closes 3261

Function signature changes required by RAFT PR #120

@drobison00 drobison00 requested a review from a team as a code owner January 19, 2021 21:47
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 19, 2021
dantegd
dantegd requested changes Jan 19, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, but will need to update the pinned raft version in

cuml/cpp/cmake/Dependencies.cmake

Line 42 in d72c54a

GIT_TAG 9161d7a238aca859453d8517bd7ad92cbd902f6a
once the raft PR is merged

@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 19, 2021
@dantegd dantegd added the 0 - Blocked Cannot progress due to external reasons label Jan 19, 2021
@dantegd dantegd mentioned this pull request Jan 19, 2021
Merged
@drobison00 drobison00 requested a review from a team as a code owner January 20, 2021 20:31
@drobison00
Copy link
Contributor Author

@dantegd Patch looks good to me. 1 failure related to a FAISS OOM error, that isn't related to these changes.

@drobison00
Copy link
Contributor Author

rerun tests

@JohnZed JohnZed removed the 0 - Blocked Cannot progress due to external reasons label Jan 21, 2021
@drobison00 drobison00 added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels Jan 21, 2021
@dantegd dantegd merged commit 6b5e7ff into rapidsai:branch-0.18 Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond CMake Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function libcuml non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drobison00 @dantegd @JohnZed