Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] API update to match RAFT PR #120 #1343

Merged
merged 3 commits into from
Jan 21, 2021
Merged

[REVIEW] API update to match RAFT PR #120 #1343

merged 3 commits into from
Jan 21, 2021

Conversation

drobison00
Copy link
Contributor

Function signature changes required by RAFT PR #120

@drobison00 drobison00 requested a review from a team as a code owner January 19, 2021 22:40
@drobison00 drobison00 mentioned this pull request Jan 19, 2021
Merged
@BradReesWork BradReesWork requested a review from afender January 20, 2021 18:02
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 20, 2021
@BradReesWork BradReesWork added this to the 0.18 milestone Jan 20, 2021
@drobison00
Copy link
Contributor Author

Had to resolve a conflict with some other changes that were pending for raft. Updating the git tag, re-running the build locally, and fixing style check errors now.

@drobison00 drobison00 requested a review from a team as a code owner January 20, 2021 21:59
afender
afender approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BradReesWork BradReesWork merged commit 7596db6 into rapidsai:branch-0.18 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afender afender afender approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
0.18
Development

Successfully merging this pull request may close these issues.
3 participants
@drobison00 @BradReesWork @afender