Skip to content

Commit

Permalink
[REVIEW] Make NCCL root initialization configurable. (#120)
Browse files Browse the repository at this point in the history
* Initial fixes

* Add worker root node ability, and unit tests

* Add logging and improve verbose usage

* Fix typos, add better docs info

* More logging updates

* Update changelog

* Fix test_comms.py style issues

* Style updates

* Style updates

* Style updates

* Feedback updates

* Feedback updates - consolidate code, merge worker_state and scheduler_state functions

* Consolidate test code paths

* Style updates.

* Add default state object to get_raft_comm_state to improve cuml compatibility

* Style fix

Co-authored-by: Devin Robison <[email protected]>
  • Loading branch information
drobison00 and drobison00 authored Jan 20, 2021
1 parent b5454cf commit 87efed0
Show file tree
Hide file tree
Showing 4 changed files with 473 additions and 143 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
- PR #103: Epsilon parameter for Cholesky rank one update
- PR #100: Add divyegala as codeowner
- PR #111: Cleanup gpuCI scripts
- PR #120: Update NCCL init process to support root node placement.

## Bug Fixes
- PR #106: Specify dependency branches to avoid pip resolver failure
Expand Down
Loading

0 comments on commit 87efed0

Please sign in to comment.