fix climits dups fix #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2021
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Apr 7, 2021
replace `#include <climits>` with `#include <cuda/std/climits>` to eliminate "incompatible redefinition" warnings. Also fixes a preprocessor typo. note: while it's safe to merge this PR prior to rapidsai/jitify#13, both are required to eliminate incompatible redefinition warnings. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Nghia Truong (https://github.com/ttnghia) - Keith Kraus (https://github.com/kkraus14) - David Wendt (https://github.com/davidwendt) URL: #7894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-processing jitify2 kernels outputs lots of warnings because both
climitsandcuda/std/climitsare included in jit-compiled source code. This is because jitify prefersclimitswhereas cudf preferscuda/std/climits. I believe these warnings didn't present in jitify1 because we were ignoring much of it's output. Now, they've become annoying. To get rid of them, we need to use one or the other. Since cudf usescuda/std/climits, I've updated jitify to include the that for jit-compiled sources.This is a hacky fix, and we should examine how to let jitify2 work well with any code's choice of includes.