Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable verbose output for jitify_preprocess #7886

Merged

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Apr 7, 2021

Remove -v option from jitify_preprocess invocation to reduce "Found #include ..."-like output during builds.

@cwharris cwharris requested a review from a team as a code owner April 7, 2021 16:36
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Apr 7, 2021
@cwharris cwharris added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Apr 7, 2021
@kkraus14 kkraus14 added the improvement Improvement / enhancement to an existing function label Apr 7, 2021
@kkraus14 kkraus14 added bug Something isn't working 5 - Ready to Merge Testing and reviews complete, ready to merge and removed improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Apr 7, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 7, 2021

@gpucibot merge

@davidwendt
Copy link
Contributor

davidwendt commented Apr 7, 2021

Does this remove the warnings too?

cuda/std/climits(29): warning: incompatible redefinition of macro "ULONG_MAX"
climits(34): here
cuda/std/climits(34): warning: incompatible redefinition of macro "LLONG_MIN"
climits(37): here
cuda/std/climits(35): warning: incompatible redefinition of macro "LLONG_MAX"
climits(36): here
cuda/std/climits(36): warning: incompatible redefinition of macro "ULLONG_MAX"
climits(38): here

Actually, I see that it doesn't
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.0/2280/consoleFull

@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 7, 2021

Does this remove the warnings too?

cuda/std/climits(29): warning: incompatible redefinition of macro "ULONG_MAX"
climits(34): here
cuda/std/climits(34): warning: incompatible redefinition of macro "LLONG_MIN"
climits(37): here
cuda/std/climits(35): warning: incompatible redefinition of macro "LLONG_MAX"
climits(36): here
cuda/std/climits(36): warning: incompatible redefinition of macro "ULLONG_MAX"
climits(38): here

Actually, I see that it doesn't
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.0/2280/consoleFull

No, we're going to tackle that in another follow up as that requires changes in jitify as well.

@cwharris
Copy link
Contributor Author

cwharris commented Apr 7, 2021

@davidwendt here's part of what's necessary to get rid of the "incompatible redefinition" warnings. The other part has to occur in cudf where we're using climits instead of cuda/std/climits. rapidsai/jitify#13

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #7886 (f8532b7) into branch-0.19 (7871e7a) will increase coverage by 0.88%.
The diff coverage is n/a.

❗ Current head f8532b7 differs from pull request most recent head cb18528. Consider uploading reports for the commit cb18528 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7886      +/-   ##
===============================================
+ Coverage        81.86%   82.74%   +0.88%     
===============================================
  Files              101      103       +2     
  Lines            16884    17701     +817     
===============================================
+ Hits             13822    14647     +825     
+ Misses            3062     3054       -8     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <0.00%> (-3.99%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e947c...cb18528. Read the comment docs.

@rapids-bot rapids-bot bot merged commit b651949 into rapidsai:branch-0.19 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CMake CMake build issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants