Skip to content

Commit

Permalink
fix "incompatible redefinition" warnings (#7894)
Browse files Browse the repository at this point in the history
replace `#include <climits>` with `#include <cuda/std/climits>` to eliminate "incompatible redefinition" warnings.

Also fixes a preprocessor typo.

note: while it's safe to merge this PR prior to rapidsai/jitify#13, both are required to eliminate incompatible redefinition warnings.

Authors:
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Keith Kraus (https://github.com/kkraus14)
  - David Wendt (https://github.com/davidwendt)

URL: #7894
  • Loading branch information
cwharris authored Apr 7, 2021
1 parent a06d2dc commit 2958719
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cpp/include/cudf/utilities/bit.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#pragma once

#include <cassert>
#include <climits>
#include <cuda/std/climits>
#include <cudf/types.hpp>

/**
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/jit/cache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ std::string get_program_cache_dir()
{
#if defined(JITIFY_USE_CACHE)
return get_cache_dir().string();
#elif
#else
return {};
#endif
}
Expand Down
2 changes: 1 addition & 1 deletion cpp/tests/unary/math_ops_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include <cudf_test/column_wrapper.hpp>
#include <cudf_test/type_lists.hpp>

#include <climits>
#include <cuda/std/climits>
#include <vector>

template <typename T>
Expand Down

0 comments on commit 2958719

Please sign in to comment.