Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "incompatible redefinition" warnings #7894

Merged

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Apr 7, 2021

replace #include <climits> with #include <cuda/std/climits> to eliminate "incompatible redefinition" warnings.

Also fixes a preprocessor typo.

note: while it's safe to merge this PR prior to rapidsai/jitify#13, both are required to eliminate incompatible redefinition warnings.

@cwharris cwharris added 3 - Ready for Review Ready for review by team depends on libcudf non-breaking Non-breaking change labels Apr 7, 2021
@cwharris cwharris requested a review from a team as a code owner April 7, 2021 19:18
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 7, 2021
@cwharris cwharris changed the title Jitify2 stop using climits make jitify2 headers include cuda/std/climits instead of climits Apr 7, 2021
@cwharris cwharris requested review from kkraus14 and davidwendt and removed request for rgsl888prabhu April 7, 2021 19:23
@cwharris cwharris changed the title make jitify2 headers include cuda/std/climits instead of climits fix "incompatible redefinition" warnings Apr 7, 2021
@kkraus14 kkraus14 added the bug Something isn't working label Apr 7, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 7, 2021

@gpucibot merge

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #7894 (7876959) into branch-0.19 (7871e7a) will increase coverage by 0.88%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7894      +/-   ##
===============================================
+ Coverage        81.86%   82.74%   +0.88%     
===============================================
  Files              101      103       +2     
  Lines            16884    17701     +817     
===============================================
+ Hits             13822    14647     +825     
+ Misses            3062     3054       -8     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <0.00%> (-3.99%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b651949...7876959. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 2958719 into rapidsai:branch-0.19 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants