-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "incompatible redefinition" warnings #7894
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-0.19
from
cwharris:jitify2-stop-using-climits
Apr 7, 2021
Merged
fix "incompatible redefinition" warnings #7894
rapids-bot
merged 5 commits into
rapidsai:branch-0.19
from
cwharris:jitify2-stop-using-climits
Apr 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isable-verbose-output
cwharris
added
3 - Ready for Review
Ready for review by team
depends on libcudf
non-breaking
Non-breaking change
labels
Apr 7, 2021
ttnghia
approved these changes
Apr 7, 2021
cwharris
changed the title
Jitify2 stop using climits
make jitify2 headers include cuda/std/climits instead of climits
Apr 7, 2021
cwharris
requested review from
kkraus14 and
davidwendt
and removed request for
rgsl888prabhu
April 7, 2021 19:23
cwharris
changed the title
make jitify2 headers include cuda/std/climits instead of climits
fix "incompatible redefinition" warnings
Apr 7, 2021
kkraus14
approved these changes
Apr 7, 2021
davidwendt
approved these changes
Apr 7, 2021
@gpucibot merge |
kkraus14
added
5 - Ready to Merge
Testing and reviews complete, ready to merge
and removed
3 - Ready for Review
Ready for review by team
labels
Apr 7, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7894 +/- ##
===============================================
+ Coverage 81.86% 82.74% +0.88%
===============================================
Files 101 103 +2
Lines 16884 17701 +817
===============================================
+ Hits 13822 14647 +825
+ Misses 3062 3054 -8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
#include <climits>
with#include <cuda/std/climits>
to eliminate "incompatible redefinition" warnings.Also fixes a preprocessor typo.
note: while it's safe to merge this PR prior to rapidsai/jitify#13, both are required to eliminate incompatible redefinition warnings.