Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] prms.whiten is modifying the components in PCA during transform() and inverse_transform() #2830

Closed
cjnolet opened this issue Sep 16, 2020 · 4 comments · Fixed by #4099
Closed

[BUG] prms.whiten is modifying the components in PCA during transform() and inverse_transform() #2830

cjnolet opened this issue Sep 16, 2020 · 4 comments · Fixed by #4099
Assignees
@divyegala
Labels
bug Something isn't working CUDA / C++ CUDA issue

Comments

@cjnolet
Copy link
Member

cjnolet commented Sep 16, 2020

I noticed this while investigating #2804. After training, nothing should be modifying the trained parameters, however, when whiten=True, the components are being modified in transform() and inverse_transform().

In this case, we should either be making a copy of the components, or possibly figure out how to perform the operations directly on the output.
@cjnolet cjnolet added bug Something isn't working CUDA / C++ CUDA issue labels Sep 16, 2020
@cjnolet cjnolet mentioned this issue Sep 16, 2020
Merged
This was referenced Sep 17, 2020
Closed
Merged
@cjnolet cjnolet mentioned this issue Oct 14, 2020
Closed
@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@dantegd
Copy link
Member

dantegd commented May 12, 2021

@divyegala just wanted to ask since you're assigned if you have any updates on the status of this?

@divyegala
Copy link
Member

@dantegd sorry, no updates! Is it something we are trying to get in for 21.06?

@divyegala divyegala mentioned this issue Jul 26, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 27, 2021
@divyegala
Creating copy of components in PCA transform and inverse transform (#…
6be9571 
…4099)

closes #2830

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4099
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
@divyegala
Creating copy of components in PCA transform and inverse transform (r…
1a69226 
…apidsai#4099)

closes rapidsai#2830

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@divyegala divyegala

Labels
bug Something isn't working CUDA / C++ CUDA issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Creating copy of components in PCA transform and inverse transform divyegala/cuml
4 participants
@dantegd @cjnolet @mike-wendt @divyegala