Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Small fixes for mid-release bug squash #2829

Merged
merged 11 commits into from
Sep 18, 2020
Merged

[REVIEW] Small fixes for mid-release bug squash #2829

merged 11 commits into from
Sep 18, 2020

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Sep 16, 2020

Closes #2804
Closes #2790

@cjnolet cjnolet added bug Something isn't working CUDA / C++ CUDA issue Cython / Python Cython or Python issue labels Sep 16, 2020
@cjnolet cjnolet requested a review from a team as a code owner September 16, 2020 16:29
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@cjnolet cjnolet requested a review from a team as a code owner September 16, 2020 17:57
@cjnolet
Copy link
Member Author

cjnolet commented Sep 16, 2020

Opened #2830 for related bug

@cjnolet cjnolet changed the title [WIP] Small fixes for mid-release bug squash [REVIEW] Small fixes for mid-release bug squash Sep 16, 2020
dantegd
dantegd approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjnolet cjnolet added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 17, 2020
@cjnolet
Copy link
Member Author

cjnolet commented Sep 17, 2020

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Sep 17, 2020

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Sep 17, 2020

This PR has failed twice now for completely unrelated tests.

@cjnolet
Copy link
Member Author

cjnolet commented Sep 18, 2020

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Sep 18, 2020

rerun tests

@cjnolet cjnolet merged commit 57e7feb into rapidsai:branch-0.16 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CUDA / C++ CUDA issue Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
4 participants
@cjnolet @GPUtester @dantegd @JohnZed