Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating copy of components in PCA transform and inverse transform #4099

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Creating copy of components in PCA transform and inverse transform #4099

merged 2 commits into from
Jul 27, 2021

Conversation

divyegala
Copy link
Member

closes #2830

@divyegala divyegala requested a review from a team as a code owner July 26, 2021 17:17
@divyegala divyegala added bug Something isn't working CUDA / C++ CUDA issue non-breaking Non-breaking change and removed CUDA/C++ labels Jul 26, 2021
@divyegala divyegala added the 3 - Ready for Review Ready for review by team label Jul 26, 2021
@dantegd
Copy link
Member

dantegd commented Jul 27, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6be9571 into rapidsai:branch-21.08 Jul 27, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@divyegala
Creating copy of components in PCA transform and inverse transform (r…
1a69226 
…apidsai#4099)

closes rapidsai#2830

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CUDA / C++ CUDA issue CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] prms.whiten is modifying the components in PCA during transform() and inverse_transform()
2 participants
@divyegala @dantegd