[REVIEW] Clean up paramsPCA #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was partially removed in rapidsai#98/rapidsai#125. Only COV_EIG_DQ and COV_EIG_JACOBI are actually supported. `random_state` is only used by ARPACK and randomized solvers, so can be remove also.
Unused, and confusing because there are lots of PCA functions with `float* trans_input` params.
Only `n_iterations` is used. Ref rapidsai#2833
|
Can one of the admins verify this patch? |
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
zbjornson
force-pushed
the
bug-pca-params
branch
from
d0225ba to
f02d121
Compare
dantegd
approved these changes
Sep 22, 2020
dantegd
added
the
5 - Ready to Merge
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages and #2833:
RANDOMIZEDsolver. (I wasn't positive what to do in cpp/test/sg/tsvd_test.cu.)bool trans_inputmax_sweepsanditerated_powercopyparam, possibly related to [BUG] prms.whiten is modifying the components in PCA during transform() and inverse_transform() #2830