[REVIEW] Remove pca randomized solver option
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkraus14
approved these changes
Jan 23, 2019
zbjornson
added a commit
to zbjornson/cuml
that referenced
this pull request
Sep 21, 2020
This was partially removed in rapidsai#98/rapidsai#125. Only COV_EIG_DQ and COV_EIG_JACOBI are actually supported. `random_state` is only used by ARPACK and randomized solvers, so can be remove also.
dantegd
pushed a commit
that referenced
this pull request
Sep 22, 2020
* Remove remaining parts of RANDOMIZED PCA solver This was partially removed in #98/#125. Only COV_EIG_DQ and COV_EIG_JACOBI are actually supported. `random_state` is only used by ARPACK and randomized solvers, so can be remove also. * Remove unused bool paramsSolver.trans_input Unused, and confusing because there are lots of PCA functions with `float* trans_input` params. * Remove unused max_sweeps and iterated_power params Only `n_iterations` is used. Ref #2833 * Add TODO for unused copy param * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
randomizedpca solver optionrandomizedsolver option.