Allow runtime has_nulls parameter for row operators #9623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
|
Current code reference of template approach for developer (me): https://godbolt.org/z/TbKqq6Tj6 |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9623 +/- ##
================================================
- Coverage 10.49% 10.44% -0.05%
================================================
Files 119 119
Lines 20305 20422 +117
================================================
+ Hits 2130 2133 +3
- Misses 18175 18289 +114
Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
jrhemstad
reviewed
Nov 29, 2021
jrhemstad
reviewed
Nov 29, 2021
jrhemstad
approved these changes
Nov 30, 2021
jrhemstad
reviewed
Dec 1, 2021
|
Most of the changes in this PR are in headers and the .cu files were merely updated to reflect the new interfaces. There are a few files here where the new runtime (dynamic) check was employed. Here are a list of build time improvements for those files and a few others:
The libcudf.so file was also reduced by 10MB. My local build is about 200MB right now. |
ttnghia
approved these changes
Dec 2, 2021
codereport
approved these changes
Dec 3, 2021
ttnghia
reviewed
Dec 3, 2021
davidwendt
added
5 - Ready to Merge
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
Follow on PR for this comment: #9623 (comment) The join hasher and equality-comparator were previously hardcoded with `has_nulls=true` (and migrated to `nullate::YES`) to help minimize code size. The new `nullate::DYNAMIC` allows for runtime checking of nulls so this can now be used here instead. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Jake Hemstad (https://github.com/jrhemstad) - Vukasin Milovanovic (https://github.com/vuule) URL: #9902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6952
This PR allows the
has_nullstemplate parameter for row operators to be used a runtime parameter in places where the null-handling logic has little to no affect on runtime performance.This can improve compile time as described in #6952.
This will also close #9152 and #9580