[FEA] Enable dynamic "has_nulls" for row operators #9580
Labels
feature request
New feature or request
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
Is your feature request related to a problem? Please describe.
The
row_lexicographic_comparator
androw_equality_comparator
have ahas_nulls
non-type template parameter to allow optimizing away the more expensive null handling code.While this is nice in cases where the null logic actually impacts performance, there are times where it doesn't. In the cases where it doesn't matter for performance, it needlessly increases compile time by having two versions of a kernel (
has_nulls==true
andhas_nulls==false
).We should make it so this information can be dynamic in addition to static.
Describe the solution you'd like
Similar to
optional_iterator
change thehas_nulls
to have three options:The implementation should be specialized to ignore the
has_nulls
dynamic value for the two static cases.The text was updated successfully, but these errors were encountered: