Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update row_equality_comparator to use null_equality enum instead of bool #9152

Closed
jrhemstad opened this issue Aug 31, 2021 · 0 comments · Fixed by #9623
Closed

[FEA] Update row_equality_comparator to use null_equality enum instead of bool #9152

jrhemstad opened this issue Aug 31, 2021 · 0 comments · Fixed by #9623
Assignees
@davidwendt
Labels
feature request New feature or request good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code.

Comments

@jrhemstad
Copy link
Contributor

jrhemstad commented Aug 31, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

The row_equality_comparator constructor currently accepts a bool to indicate if nulls are considered equal or not. In libcudf, we prefer to use scoped enums instead of bools and we already have a null_equality enum for this exact purpose.

Describe the solution you'd like

Update the row_equality_comparator to take a null_equality enum argument in lieu of the bool.
@jrhemstad jrhemstad added feature request New feature or request good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code. tech debt labels Aug 31, 2021
@davidwendt davidwendt self-assigned this Nov 12, 2021
@davidwendt davidwendt mentioned this issue Nov 17, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #9623 Dec 6, 2021
rapids-bot bot pushed a commit that referenced this issue Dec 6, 2021
@davidwendt
Allow runtime has_nulls parameter for row operators (#9623)
8002cbd 
Closes #6952 

This PR allows the `has_nulls` template parameter for row operators to be used a runtime parameter in places where the null-handling logic has little to no affect on runtime performance. 
This can improve compile time as described in #6952.

This will also close #9152 and #9580

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Jake Hemstad (https://github.com/jrhemstad)
  - Nghia Truong (https://github.com/ttnghia)
  - Conor Hoekstra (https://github.com/codereport)

URL: #9623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwendt davidwendt

Labels
feature request New feature or request good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow runtime has_nulls parameter for row operators davidwendt/cudf
2 participants
@jrhemstad @davidwendt