Use dynamic nullate for join hasher and equality comparator

[davidwendt]

Follow on PR for this comment: #9623 (comment)

The join hasher and equality-comparator were previously hardcoded with has_nulls=true (and migrated to nullate::YES) to help minimize code size. The new nullate::DYNAMIC allows for runtime checking of nulls so this can now be used here instead.

[jrhemstad]

Any chance this actually improved performance for tables without nulls?

[davidwendt]

Any chance this actually improved performance for tables without nulls?

Sadly no. I ran JOIN_BENCH and saw no real changes in performance.

[codecov]

Codecov Report

Merging #9902 (784e644) into branch-22.02 (967a333) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 784e644 differs from pull request most recent head 2bd7d24. Consider uploading reports for the commit 2bd7d24 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.02    #9902      +/-   ##
================================================
- Coverage         10.49%   10.40%   -0.09%     
================================================
  Files               119      119              
  Lines             20305    20503     +198     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18369     +194     

Impacted Files	Coverage Δ
python/dask_cudf/dask_cudf/sorting.py	92.30% <0.00%> (-0.61%)	⬇️
python/cudf/cudf/__init__.py	0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py	0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py	0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py	0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py	0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py	0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py	0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py	0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py	0.00% <0.00%> (ø)
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c3f735...2bd7d24. Read the comment docs.

[davidwendt]

@gpucibot merge