[REVIEW] Fix issues with building cudf in a non-conda environment #7647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
|
Validating install of last step pending since compilation is blocked by: #7563, so tagging this one as blocked. |
kkraus14
reviewed
Mar 19, 2021
mike-wendt
reviewed
Mar 19, 2021
galipremsagar
added
2 - In Progress
galipremsagar
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7647 +/- ##
===============================================
+ Coverage 81.86% 82.66% +0.79%
===============================================
Files 101 103 +2
Lines 16884 17563 +679
===============================================
+ Hits 13822 14518 +696
+ Misses 3062 3045 -17
Continue to review full report at Codecov.
|
kkraus14
approved these changes
Apr 1, 2021
galipremsagar
added
the
4 - Needs Review
kkraus14
added
5 - Ready to Merge
|
@gpucibot merge |
kkraus14
added
0 - Waiting on Author
|
rerun tests |
kkraus14
added
5 - Ready to Merge
|
@gpucibot merge |
ajschmidt8
reviewed
Apr 1, 2021
Co-authored-by: AJ Schmidt <[email protected]>
Co-authored-by: AJ Schmidt <[email protected]>
ajschmidt8
approved these changes
Apr 1, 2021
|
rerun tests |
1 similar comment
|
rerun tests |
This was referenced Mar 30, 2022
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 30, 2022
This PR removes some pip requirements files that are no longer used. These were previously introduced to support #7647 but that Dockerfile is no longer maintained in this repository. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - https://github.com/brandon-b-miller - GALI PREM SAGAR (https://github.com/galipremsagar) - https://github.com/jakirkham URL: #10543
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Mar 30, 2022
This PR removes a pip requirements file that is no longer used. This were previously introduced to support rapidsai/cudf#7647 but that Dockerfile is no longer maintained. See also rapidsai/cudf#10543. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #1015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension to rapidsai/rmm#733
Also resolves: #7578
This PR introduces fixes to
setup.pyin cudf build and also adds a DockerFile with which one can create a container with cudf fully built from source. Arrow & rmm will also be built from the source. This PR also contains arequirements.txtwhich has packages needed by cudf and that are available to install via pip.