Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] setup.py files contain the wrong Python versions #7578

Closed
mike-wendt opened this issue Mar 12, 2021 · 1 comment · Fixed by #7647
Closed

[BUG] setup.py files contain the wrong Python versions #7578

mike-wendt opened this issue Mar 12, 2021 · 1 comment · Fixed by #7647
Assignees
@galipremsagar
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@mike-wendt
Copy link
Contributor

Describe the bug
The setup.py files in the folders within the /python directory contain the following snippets:

        "Programming Language :: Python :: 3.6",
        "Programming Language :: Python :: 3.7",

We currently only support 3.7/3.8

Steps/Code to reproduce bug
Examine these files:

Expected behavior
To be updated to match the current supported Python versions

Environment overview (please complete the following information)

  • Environment location: N/A found in source code
  • Method of cuDF install: N/A found in source code

Environment details
N/A

Additional context
N/A
@mike-wendt mike-wendt added bug Something isn't working Needs Triage Need team to review and classify labels Mar 12, 2021
@kkraus14 kkraus14 added Python Affects Python cuDF API. and removed Needs Triage Need team to review and classify labels Mar 13, 2021
@kkraus14
Copy link
Collaborator

@galipremsagar minor issue that can be fixed as part of the larger setup.py cleanup

@galipremsagar galipremsagar mentioned this issue Mar 24, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #7647 Apr 1, 2021
rapids-bot bot pushed a commit that referenced this issue Apr 1, 2021
@galipremsagar
Fix issues with building cudf in a non-conda environment (#7647)
f4d5bde 
Extension to rapidsai/rmm#733

Also resolves: #7578

This PR introduces fixes to `setup.py` in cudf build and also adds a DockerFile with which one can create a container with cudf fully built from source. Arrow & rmm will also be built from the source. This PR also contains a `requirements.txt` which has packages needed by cudf and that are available to install via pip.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Devavret Makkar (https://github.com/devavret)
  - Keith Kraus (https://github.com/kkraus14)
  - Christopher Harris (https://github.com/cwharris)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #7647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Fix issues with building cudf in a non-conda environment galipremsagar/cudf
3 participants
@mike-wendt @kkraus14 @galipremsagar