Eliminate literal parameters to uvector::set_element_async and device_scalar::set_value #7563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
3 - Ready for Review
Comment on lines
+52
to
+55
| auto const in{4}; | ||
| auto const out{1}; | ||
| input->set_value(in); | ||
| output->set_value(out); |
|
This will not pass CI until rapidsai/rmm#725 is merged. |
harrism
requested review from
jrhemstad,
nvdbaranec and
devavret
and removed request for
jrhemstad
|
rerun tests |
devavret
approved these changes
Mar 18, 2021
trxcllnt
approved these changes
Mar 18, 2021
|
rerun tests |
hyperbolic2346
approved these changes
Mar 19, 2021
kkraus14
added
the
5 - Ready to Merge
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7563 +/- ##
===============================================
+ Coverage 81.86% 82.49% +0.62%
===============================================
Files 101 101
Lines 16884 17402 +518
===============================================
+ Hits 13822 14355 +533
+ Misses 3062 3047 -15
Continue to review full report at Codecov.
|
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rapidsai/rmm#725 is merged, this PR updates cuspatial to eliminate passing literal values to
device_scalar::set_value.Note there are still similar issues with uses of
cudf::scalarthat need to be addressed. But I wanted to get this open before the end of the week. This can be merged after RMM 725 is merged to fix the build, so I think thescalarissues should be fixed separately.