Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NVTX from GitHub #6534

Closed
wants to merge 10 commits into from
Closed

Use NVTX from GitHub #6534

wants to merge 10 commits into from

Conversation

jrhemstad
Copy link
Contributor

@jrhemstad jrhemstad commented Oct 14, 2020 •
edited by kkraus14
Loading

closes #6476

Adds CPM and uses it to fetch NVTX.

This required bumping the cmake minimum version to 3.18 to get support for SOURCE_SUBDIR.

This currently depends on my fork of NVTX until NVIDIA/NVTX#14 is merged.

Depends on rapidsai/integration#156

@jrhemstad jrhemstad requested review from a team as code owners October 14, 2020 22:50
@jrhemstad jrhemstad marked this pull request as draft October 14, 2020 22:50
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@jrhemstad jrhemstad added the 2 - In Progress Currently a work in progress label Oct 14, 2020
kkraus14
kkraus14 reviewed Oct 14, 2020
View reviewed changes
cpp/cmake/CPM.cmake Outdated Show resolved Hide resolved
@kkraus14 kkraus14 added the CMake CMake build issue label Oct 16, 2020
@jrhemstad
Copy link
Contributor Author

rerun tests

@kkraus14
Copy link
Collaborator

FYI the gpu tests will fail unless you temporarily do something like https://github.com/rapidsai/rmm/pull/604/files#diff-285f239638b8b5c5499ef5fda2e3db69adda7045e81556b4f2df478e99ab6263R51-R52 to bump cmake to 3.18.

@jrhemstad jrhemstad mentioned this pull request Oct 29, 2020
Closed
@harrism
Copy link
Member

harrism commented Nov 23, 2020

@jrhemstad should we push this to 0.18?

@harrism
Copy link
Member

harrism commented Dec 3, 2020

Move to 0.18

@github-actions
Copy link

This PR has been marked stale due to no recent activity in the past 30d. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be marked rotten if there is no activity in the next 60d.

@github-actions github-actions bot added the stale label Feb 16, 2021
@jrhemstad jrhemstad added 0 - Blocked Cannot progress due to external reasons and removed inactive-30d labels May 4, 2021
@harrism harrism added the libcudf Affects libcudf (C++/CUDA) code. label May 26, 2021
@harrism
Copy link
Member

harrism commented May 26, 2021

@jrhemstad I missed this because it lacked the libcudf label. Plans for it?

@jrhemstad
Copy link
Contributor Author

Moving to 21.08...

@bdice
Copy link
Contributor

bdice commented Aug 26, 2022

Closing as stale - this PR would need to be redone with rapids-cmake in order to resolve #6476, and it seems we may still be waiting on a new release/tag of NVTX upstream.

@bdice bdice closed this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 left review comments

@harrism harrism harrism left review comments

@devavret devavret Awaiting requested review from devavret

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu

Assignees
No one assigned
Labels
0 - Blocked Cannot progress due to external reasons 2 - In Progress Currently a work in progress CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Use official NVTX from GitHub
5 participants
@jrhemstad @GPUtester @kkraus14 @harrism @bdice