-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul C/CPP cmake configuration #14
Conversation
Looks good to me Jake. Feel free to merge unless you have some clever ideas for my comment above about preferring C++14 over C++11 if there's no explicit requirement for C++11. |
OK, reviewed the new changes for requiring C++14. This looks good to merge. |
Great. Can you merge it? I don't have permissions to merge to the repo. |
Is the git hash stuff ok now? If so I can merge this. |
LGTM now, thanks! |
c/
directoyr and create anvtx3-c
target for the NVTX C librarylibdl
dependency as a property of thenvtx3-c
targetnvtx3-cpp
target for the NVTX C++ library that depends on thenvtx3-c
targetnvtx3-cpp
targetc/
directory as a symlink tocpp/nvtx-c
to make it cleaner to depend on thenvtx-c
cmake target