Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Upgrade cmake to 3.18 #156

Merged
merged 2 commits into from
Nov 12, 2020
Merged

[REVIEW] Upgrade cmake to 3.18 #156

merged 2 commits into from
Nov 12, 2020

Conversation

kkraus14
Copy link
Contributor

@kkraus14 kkraus14 requested a review from a team as a code owner October 16, 2020 05:37
@kkraus14 kkraus14 added the 2 - In Progress Currenty a work in progress label Oct 16, 2020
This was referenced Oct 16, 2020
Merged
Closed
@kkraus14 kkraus14 mentioned this pull request Oct 22, 2020
Closed
@kkraus14 kkraus14 changed the base branch from branch-0.16 to branch-0.17 October 27, 2020 03:31
@kkraus14 kkraus14 changed the title [WIP] Upgrade cmake to 3.18 [REVIEW] Upgrade cmake to 3.18 Nov 12, 2020
@kkraus14 kkraus14 added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Nov 12, 2020
@ajschmidt8 ajschmidt8 merged commit 5aced79 into rapidsai:branch-0.17 Nov 12, 2020
harrism pushed a commit to rapidsai/rmm that referenced this pull request Nov 20, 2020
CMake target cleanup, formatting, linting (#604)
e7f0726 
Sets up framework for automating formatting + linting of CMake files via pre-commit, and fixes all known formatting + linting issues.

Additionally, moves compiler / linker / etc. options to the RMM target instead of using CMake global options.

Depends on: rapidsai/integration#156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkraus14 @ajschmidt8