[REVIEW] Pin cmake policies to 3.17 #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #1227 +/- ##
============================================
Coverage 57.20% 57.20%
============================================
Files 61 61
Lines 2500 2500
============================================
Hits 1430 1430
Misses 1070 1070 Continue to review full report at Codecov.
|
afender
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
I did try adding CUDA_ARCHITECTURES as part of the debugging efforts this weekend actually. It seems to go smoothly for cugraph once CUDA_ARCHITECTURES is added.
Also, I noticed this can be passed to older cmake versions concurrently with the legacy one (well, at least it built/ran locally).
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planning to upgrade to cmake 3.18 in the near future and the CUDA_ARCHITECTURES change is a breaking change, so pinning to 3.17 policies to prevent the breakages.