Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Use official NVTX from GitHub #6476

Closed
jrhemstad opened this issue Oct 9, 2020 · 8 comments · Fixed by #15178
Closed

[FEA] Use official NVTX from GitHub #6476

jrhemstad opened this issue Oct 9, 2020 · 8 comments · Fixed by #15178
Labels
0 - Blocked Cannot progress due to external reasons feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Milestone
Helps developer v...

Comments

@jrhemstad
Copy link
Contributor

Is your feature request related to a problem? Please describe.

libcudf currently vendors a prototype version of the NVTX C++ wrappers that are now hosted officially on GitHub.

Describe the solution you'd like

Remove the vendored header and instead use CMake/CPM to pull the header from GitHub.
@jrhemstad jrhemstad added feature request New feature or request tech debt labels Oct 9, 2020
@harrism
Copy link
Member

harrism commented Oct 12, 2020

The official version appears to still be in the dev branch. Any idea when it will be released?

@jrhemstad
Copy link
Contributor Author

The official version appears to still be in the dev branch. Any idea when it will be released?

Our goal is to have a tagged release done by end of October.

@jrhemstad jrhemstad mentioned this issue Oct 14, 2020
Closed
@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@harrism
Copy link
Member

harrism commented Feb 17, 2021

Still waiting on the tagged release.

@github-actions github-actions bot removed the rotten label Feb 17, 2021
@jrhemstad jrhemstad added 0 - Blocked Cannot progress due to external reasons libcudf Affects libcudf (C++/CUDA) code. labels Mar 18, 2021
@vyasr
Copy link
Contributor

vyasr commented Jul 12, 2022

@jrhemstad any idea what the blocker is on tagging a release for NVTX? The last one that I see is the June 2020 version 3.0.1 release. All of the upstream dependencies have been merged, it seems?

@jrhemstad
Copy link
Contributor Author

The necessary changes are now in the official release-v3 branch and there is a 3.1 release tag: https://github.com/NVIDIA/NVTX/releases/tag/v3.1.0

We should be good now to remove our vendored header in favor of getting nvtx from the GitHub repo.

@davidwendt
Copy link
Contributor

Will this include an equivalent fix created here #11798 ?
Or do we have to do something else to work around the warning?

@jrhemstad
Copy link
Contributor Author

Will this include an equivalent fix created here #11798 ? Or do we have to do something else to work around the warning?

I opened a PR with a fix for that warning here: NVIDIA/NVTX#61

@karthikeyann karthikeyann mentioned this issue Oct 11, 2022
Merged
3 tasks
@davidwendt davidwendt mentioned this issue Apr 20, 2023
Merged
3 tasks
@jrhemstad jrhemstad mentioned this issue Feb 13, 2024
Merged
3 tasks
@vyasr vyasr removed the tech debt label Feb 23, 2024
@bdice bdice mentioned this issue Feb 28, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Mar 8, 2024
@bdice
Use NVTX from GitHub. (#15178)
dc42182 
This PR removes the vendored copy of NVTX and instead fetches it from GitHub.

Note: Consumers of libcudf internal `detail` headers will need to provide their own NVTX. This can be done by using the CMake code in this PR (or the sample CMake code in the [NVTX README](https://github.com/NVIDIA/NVTX?tab=readme-ov-file#cmake)), and calling `target_link_libraries(your_target PRIVATE nvtx3-cpp)`.

Closes #6476.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Yunsong Wang (https://github.com/PointKernel)
  - Nghia Truong (https://github.com/ttnghia)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #15178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Blocked Cannot progress due to external reasons feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
Helps developer velocity
Development

Successfully merging a pull request may close this issue.

Use NVTX from GitHub. bdice/cudf
Use NVTX from GitHub jrhemstad/cudf
5 participants
@harrism @vyasr @GregoryKimball @jrhemstad @davidwendt