Add maybe_unused to ranges and nodiscard to start_range. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some compilers issues spurious warnings about unused variables for instances of scoped_range and unique_range. Use [[maybe_unused]] when available to silence these warnings. Likewise, added `[[nodiscard]]` when available to `start_range()` to issue a warning if a user accidently forgets to store the result of `start_range()`. It is not possible to correctly use `start_range()` without using the result to call `end_range()`.
And adds NVTX3_NO_DISCARD on all the `get()` singleton functions.
3 tasks
|
Hey @jcohen-nvidia would you mind reviewing this so we can get it merged? |
evanramos-nvidia
requested changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers issues spurious warnings about unused variables for
instances of scoped_range and unique_range. Use [[maybe_unused]] when available
to silence these warnings.
Likewise, added
[[nodiscard]]when available tostart_range()to issue a warningif a user accidently forgets to store the result of
start_range(). It is not possible to correctlyuse
start_range()without using the result to callend_range().