Deprecate legacy JSON reader options. #15558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
bdice
added
improvement
vuule
approved these changes
Apr 17, 2024
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Fixes deprecation warnings caused by changes in #15558 Most are in the `json_test.cpp` and appear like this ``` [150+7+50=206] Building CXX object tests/CMakeFiles/JSON_TEST.dir/io/json_test.cpp.o /cudf/cpp/tests/io/json_test.cpp: In member function 'virtual void JsonReaderParamTest_BasicJsonLines_Test::TestBody()': /cudf/cpp/tests/io/json_test.cpp:320:14: warning: 'cudf::io::json_reader_options_builder& cudf::io::json_reader_options_builder::legacy(bool)' is deprecated [-Wdeprecated-declarations] 317 | cudf::io::json_reader_options::builder(cudf::io::source_info{data.data(), data.size()}) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 318 | .dtypes(std::vector<data_type>{dtype<int32_t>(), dtype<double>()}) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 319 | .lines(true) | ~~~~~~~~~~~~ 320 | .legacy(is_legacy_test(test_opt)); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /cudf/cpp/tests/io/json_test.cpp:30: ``` Compiler warnings usually result in errors when building libcudf. This PR removes calls and references to legacy JSON reader features where possible. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) URL: #15563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the option for using the legacy JSON reader, so it can be removed in the next RAPIDS release.
This work follows up on a task from #15537
Checklist