Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy JSON reader options. #15558

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Deprecate legacy JSON reader options. #15558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions cpp/include/cudf/io/json.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,11 @@ class json_reader_options {
/**
* @brief Whether the legacy reader should be used.
*
* @deprecated Since 24.06
*
* @returns true if the legacy reader will be used, false otherwise
*/
bool is_enabled_legacy() const { return _legacy; }
[[deprecated]] bool is_enabled_legacy() const { return _legacy; }

/**
* @brief Whether the reader should keep quotes of string values.
Expand Down Expand Up @@ -350,9 +352,11 @@ class json_reader_options {
/**
* @brief Set whether to use the legacy reader.
*
* @deprecated Since 24.06
*
* @param val Boolean value to enable/disable the legacy reader
*/
void enable_legacy(bool val) { _legacy = val; }
[[deprecated]] void enable_legacy(bool val) { _legacy = val; }

/**
* @brief Set whether the reader should keep quotes of string values.
Expand Down Expand Up @@ -519,10 +523,12 @@ class json_reader_options_builder {
/**
* @brief Set whether to use the legacy reader.
*
* @deprecated Since 24.06
*
* @param val Boolean value to enable/disable legacy parsing
* @return this for chaining
*/
json_reader_options_builder& legacy(bool val)
[[deprecated]] json_reader_options_builder& legacy(bool val)
{
options._legacy = val;
return *this;
Expand Down
Loading