-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnings for json legacy reader #15563
Fix deprecation warnings for json legacy reader #15563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @davidwendt!
// Run test with the existing JSON lines reader using row-orient input data | ||
legacy_lines_row_orient, | ||
// Run test with the existing JSON lines reader using record-orient input data | ||
legacy_lines_record_orient, | ||
// Run test with the nested JSON lines reader using record-orient input data | ||
json_experimental_record_orient, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a follow-up item to the tracking issue to remove the word "experimental." I'll tackle that after this merges. #15537
/merge |
Description
Fixes deprecation warnings caused by changes in #15558
Most are in the
json_test.cpp
and appear like thisCompiler warnings usually result in errors when building libcudf.
This PR removes calls and references to legacy JSON reader features where possible.
Checklist