Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings for json legacy reader #15563

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes deprecation warnings caused by changes in #15558
Most are in the json_test.cpp and appear like this

[150+7+50=206] Building CXX object tests/CMakeFiles/JSON_TEST.dir/io/json_test.cpp.o
/cudf/cpp/tests/io/json_test.cpp: In member function 'virtual void JsonReaderParamTest_BasicJsonLines_Test::TestBody()':
/cudf/cpp/tests/io/json_test.cpp:320:14: warning: 'cudf::io::json_reader_options_builder& cudf::io::json_reader_options_builder::legacy(bool)' is deprecated [-Wdeprecated-declarations]
  317 |     cudf::io::json_reader_options::builder(cudf::io::source_info{data.data(), data.size()})
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  318 |       .dtypes(std::vector<data_type>{dtype<int32_t>(), dtype<double>()})
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  319 |       .lines(true)
      |       ~~~~~~~~~~~~
  320 |       .legacy(is_legacy_test(test_opt));
      |       ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /cudf/cpp/tests/io/json_test.cpp:30:

Compiler warnings usually result in errors when building libcudf.

This PR removes calls and references to legacy JSON reader features where possible.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Apr 18, 2024
@davidwendt davidwendt self-assigned this Apr 18, 2024
@davidwendt davidwendt requested a review from bdice April 18, 2024 01:37
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 18, 2024
@davidwendt davidwendt marked this pull request as ready for review April 18, 2024 12:11
@davidwendt davidwendt requested a review from a team as a code owner April 18, 2024 12:11
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @davidwendt!

// Run test with the existing JSON lines reader using row-orient input data
legacy_lines_row_orient,
// Run test with the existing JSON lines reader using record-orient input data
legacy_lines_record_orient,
// Run test with the nested JSON lines reader using record-orient input data
json_experimental_record_orient,
Copy link
Contributor

@bdice bdice Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a follow-up item to the tracking issue to remove the word "experimental." I'll tackle that after this merges. #15537

@bdice bdice mentioned this pull request Apr 18, 2024
7 tasks
@bdice
Copy link
Contributor

bdice commented Apr 18, 2024

/merge

@rapids-bot rapids-bot bot merged commit 7b9e815 into rapidsai:branch-24.06 Apr 18, 2024
70 checks passed
@davidwendt davidwendt deleted the deprecated-json-legacy branch April 18, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants