Skip to content

Commit

Permalink
Deprecate legacy JSON reader options. (#15558)
Browse files Browse the repository at this point in the history
This PR deprecates the option for using the legacy JSON reader, so it can be removed in the next RAPIDS release.

This work follows up on a task from #15537

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Muhammad Haseeb (https://github.com/mhaseeb123)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: #15558
  • Loading branch information
bdice authored Apr 17, 2024
1 parent f222b4a commit eaae68d
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions cpp/include/cudf/io/json.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,11 @@ class json_reader_options {
/**
* @brief Whether the legacy reader should be used.
*
* @deprecated Since 24.06
*
* @returns true if the legacy reader will be used, false otherwise
*/
bool is_enabled_legacy() const { return _legacy; }
[[deprecated]] bool is_enabled_legacy() const { return _legacy; }

/**
* @brief Whether the reader should keep quotes of string values.
Expand Down Expand Up @@ -350,9 +352,11 @@ class json_reader_options {
/**
* @brief Set whether to use the legacy reader.
*
* @deprecated Since 24.06
*
* @param val Boolean value to enable/disable the legacy reader
*/
void enable_legacy(bool val) { _legacy = val; }
[[deprecated]] void enable_legacy(bool val) { _legacy = val; }

/**
* @brief Set whether the reader should keep quotes of string values.
Expand Down Expand Up @@ -519,10 +523,12 @@ class json_reader_options_builder {
/**
* @brief Set whether to use the legacy reader.
*
* @deprecated Since 24.06
*
* @param val Boolean value to enable/disable legacy parsing
* @return this for chaining
*/
json_reader_options_builder& legacy(bool val)
[[deprecated]] json_reader_options_builder& legacy(bool val)
{
options._legacy = val;
return *this;
Expand Down

0 comments on commit eaae68d

Please sign in to comment.