Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate cudf::hashing::spark_murmurhash3_x86_32 #15074

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Deprecate cudf::hashing::spark_murmurhash3_x86_32 #15074

merged 1 commit into from
Feb 20, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Feb 16, 2024 •
edited
Loading

Description

The cudf::hashing::spark_murmurhash3_x86_32() function was moved to the Spark plugin since it had common code with the Spark implementation of xxhash_64 (also implemented in the plugin).
This change deprecates the API and the generic cudf::hashing::hash() function to be removed in a follow-on release.

Reference hash cleanup issue: #13706

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function breaking Breaking change labels Feb 16, 2024
@davidwendt davidwendt self-assigned this Feb 16, 2024
@github-actions github-actions bot added the CMake CMake build issue label Feb 16, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 20, 2024
@davidwendt davidwendt marked this pull request as ready for review February 20, 2024 15:14
@davidwendt davidwendt requested a review from a team as a code owner February 20, 2024 15:14
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 44686ca into rapidsai:branch-24.04 Feb 20, 2024
68 checks passed
@davidwendt davidwendt deleted the deprecate-spark-hash branch February 20, 2024 19:57
@davidwendt davidwendt mentioned this pull request Feb 20, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Feb 21, 2024
@davidwendt
Fix deprecation warnings for deprecated hash() calls (#15095)
8e68b37 
Merged #15074 too soon and missed fixing these now deprecated call warnings.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Mark Harris (https://github.com/harrism)

URL: #15095
@jlowe jlowe mentioned this pull request Feb 23, 2024
Closed
@thirtiseven thirtiseven mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @karthikeyann