Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cudf::hashing::spark_murmurhash3_x86_32 #15074

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Deprecate cudf::hashing::spark_murmurhash3_x86_32 #15074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/include/cudf/hashing.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ static constexpr uint32_t DEFAULT_HASH_SEED = 0;
*
* @returns A column where each row is the hash of a column from the input
*/
std::unique_ptr<column> hash(
[[deprecated]] std::unique_ptr<column> hash(
table_view const& input,
hash_id hash_function = hash_id::HASH_MURMUR3,
uint32_t seed = DEFAULT_HASH_SEED,
Expand Down Expand Up @@ -115,6 +115,8 @@ std::unique_ptr<table> murmurhash3_x64_128(
/**
* @brief Computes the MurmurHash3 32-bit hash value of each row in the given table
*
* @deprecated Since 24.04
*
* This function computes the hash similar to MurmurHash3_x86_32 with special processing
* to match Spark's implementation results.
*
Expand All @@ -125,7 +127,7 @@ std::unique_ptr<table> murmurhash3_x64_128(
*
* @returns A column where each row is the hash of a row from the input
*/
std::unique_ptr<column> spark_murmurhash3_x86_32(
[[deprecated]] std::unique_ptr<column> spark_murmurhash3_x86_32(
table_view const& input,
uint32_t seed = DEFAULT_HASH_SEED,
rmm::cuda_stream_view stream = cudf::get_default_stream(),
Expand Down
1 change: 0 additions & 1 deletion cpp/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ ConfigureTest(
hashing/sha256_test.cpp
hashing/sha384_test.cpp
hashing/sha512_test.cpp
hashing/spark_murmurhash3_x86_32_test.cpp
hashing/xxhash_64_test.cpp
)

Expand Down
Loading