Skip to content

Commit

Permalink
Deprecate cudf::hashing::spark_murmurhash3_x86_32 (#15074)
Browse files Browse the repository at this point in the history
The `cudf::hashing::spark_murmurhash3_x86_32()` function was moved to the Spark plugin since it had common code with the Spark implementation of `xxhash_64` (also implemented in the plugin).
This change deprecates the API and the generic `cudf::hashing::hash()` function to be removed in a follow-on release.

Reference hash cleanup issue: #13706

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Karthikeyan (https://github.com/karthikeyann)

URL: #15074
  • Loading branch information
davidwendt authored Feb 20, 2024
1 parent 047b112 commit 44686ca
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 4 additions & 2 deletions cpp/include/cudf/hashing.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ static constexpr uint32_t DEFAULT_HASH_SEED = 0;
*
* @returns A column where each row is the hash of a column from the input
*/
std::unique_ptr<column> hash(
[[deprecated]] std::unique_ptr<column> hash(
table_view const& input,
hash_id hash_function = hash_id::HASH_MURMUR3,
uint32_t seed = DEFAULT_HASH_SEED,
Expand Down Expand Up @@ -115,6 +115,8 @@ std::unique_ptr<table> murmurhash3_x64_128(
/**
* @brief Computes the MurmurHash3 32-bit hash value of each row in the given table
*
* @deprecated Since 24.04
*
* This function computes the hash similar to MurmurHash3_x86_32 with special processing
* to match Spark's implementation results.
*
Expand All @@ -125,7 +127,7 @@ std::unique_ptr<table> murmurhash3_x64_128(
*
* @returns A column where each row is the hash of a row from the input
*/
std::unique_ptr<column> spark_murmurhash3_x86_32(
[[deprecated]] std::unique_ptr<column> spark_murmurhash3_x86_32(
table_view const& input,
uint32_t seed = DEFAULT_HASH_SEED,
rmm::cuda_stream_view stream = cudf::get_default_stream(),
Expand Down
1 change: 0 additions & 1 deletion cpp/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ ConfigureTest(
hashing/sha256_test.cpp
hashing/sha384_test.cpp
hashing/sha512_test.cpp
hashing/spark_murmurhash3_x86_32_test.cpp
hashing/xxhash_64_test.cpp
)

Expand Down

0 comments on commit 44686ca

Please sign in to comment.