Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using ColumnVector.spark32BitMurmurHash3 #10487

Closed
jlowe opened this issue Feb 23, 2024 · 1 comment
Closed

Stop using ColumnVector.spark32BitMurmurHash3 #10487

jlowe opened this issue Feb 23, 2024 · 1 comment
Assignees
@gerashegalov
Labels
good first issue Good for newcomers

Comments

@jlowe
Copy link
Member

jlowe commented Feb 23, 2024

cudf is planning to remove the Spark-specific MurmurHash3 kernel since it has been implemented in the Hash class in spark-rapids-jni. See rapidsai/cudf#15074 for details. The code needs to be updated to stop using ai.rapids.cudf.ColumnVector.spark32BitMurmurHash3 and start using com.nvidia.spark.rapids.jni.Hash.murmurHash32.
@jlowe jlowe added good first issue Good for newcomers ? - Needs Triage Need team to review and classify labels Feb 23, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 27, 2024
@mattahrens mattahrens mentioned this issue Mar 12, 2024
Closed
@sameerz sameerz mentioned this issue Mar 27, 2024
Merged
3 tasks
gerashegalov added a commit to gerashegalov/spark-rapids that referenced this issue Apr 1, 2024
@gerashegalov
Substitute murmurHash32 for spark32BitMurmurHash3
ca14825 
Fixes NVIDIA#10487

Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov mentioned this issue Apr 1, 2024
Merged
gerashegalov added a commit that referenced this issue Apr 3, 2024
@gerashegalov
Substitute murmurHash32 for spark32BitMurmurHash3 (#10652)
44421e9 
Fixes #10487

Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov
Copy link
Collaborator

fixed by #10652

wjxiz1992 pushed a commit to nvliyuan/yuali-spark-rapids that referenced this issue Apr 7, 2024
@gerashegalov @wjxiz1992
Substitute murmurHash32 for spark32BitMurmurHash3 (NVIDIA#10652)
ad57051 
Fixes NVIDIA#10487

Signed-off-by: Gera Shegalov <[email protected]>
wjxiz1992 pushed a commit to nvliyuan/yuali-spark-rapids that referenced this issue Apr 7, 2024
@gerashegalov @wjxiz1992
Substitute murmurHash32 for spark32BitMurmurHash3 (NVIDIA#10652)
a3c1f5d 
Fixes NVIDIA#10487

Signed-off-by: Gera Shegalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlowe @gerashegalov @mattahrens