Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly depend on zlib in conda recipes #14018

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Explicitly depend on zlib in conda recipes #14018

merged 4 commits into from
Aug 31, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Aug 31, 2023 •
edited
Loading

Description

We were previously obtaining zlib transitively through our cmake dependency, but since the 3.27.4 conda package, this dependency no longer exists. Therefore we must depend on zlib ourselves.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
Explicitly depend on zlib in conda recipes
a09dda6 
We were previously obtaining zlib transitively through our cmake
dependency, but since the 3.27.4 conda package, this dependency no
longer exists. Therefore we must depend on zlib ourselves.
@wence- wence- requested a review from a team as a code owner August 31, 2023 15:32
@github-actions github-actions bot added the conda label Aug 31, 2023
bdice
bdice reviewed Aug 31, 2023
View reviewed changes
dependencies.yaml Outdated
@@ -179,6 +179,7 @@ dependencies:
- c-compiler
- cxx-compiler
- dlpack>=0.5,<0.6.0a0
- zlib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wence- Can you comment on where/how we use zlib? Does it need to be in the conda package dependencies (meta.yml for libcudf, or cudf, …) as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue documenting the problems you see in builds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now: #14021

Copy link
Contributor

@vyasr vyasr Aug 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support zlib compression/decompression in ORC reading/writing, so we should be including it in our recipe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was missing: #14021 (comment)

ajschmidt8
ajschmidt8 reviewed Aug 31, 2023
View reviewed changes
conda/recipes/libcudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libcudf/meta.yaml Outdated Show resolved Hide resolved
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 31, 2023
bdice
bdice approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, this looks right to me.

vyasr
vyasr requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vuule do you know if there's a specific version of zlib that we require for our use cases? Wondering if we need a lower bound here.

ajschmidt8
ajschmidt8 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@vuule
Copy link
Contributor

vuule commented Aug 31, 2023

@vuule do you know if there's a specific version of zlib that we require for our use cases? Wondering if we need a lower bound here.

I'm pretty sure we go back quite a bit and have the same API available. I'm looking at their changelog, and there are bug fixes in every release. Based on this, should we make 1.2.13 the lower bound? It was released Oct 2022.

@wence-
Copy link
Contributor Author

wence- commented Aug 31, 2023

@vuule do you know if there's a specific version of zlib that we require for our use cases? Wondering if we need a lower bound here.

I'm pretty sure we go back quite a bit and have the same API available. I'm looking at their changelog, and there are bug fixes in every release. Based on this, should we make 1.2.13 the lower bound? It was released Oct 2022.

Done.

vyasr
vyasr approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower bound looks reasonable to me.

@vyasr
Copy link
Contributor

vyasr commented Aug 31, 2023

/merge

This was referenced Aug 31, 2023
Merged
Merged
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 31, 2023
@rapids-bot rapids-bot bot merged commit a2fd688 into rapidsai:branch-23.10 Aug 31, 2023
@wence- wence- deleted the wence/fix/depend-zlib-explicit branch August 31, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] libcudf CI builds failing due to lack of zlib package
6 participants
@wence- @vuule @vyasr @bdice @ajschmidt8 @galipremsagar